Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sudo to disallow root permission #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gmag11
Copy link
Contributor

@gmag11 gmag11 commented Nov 17, 2023

My proposal to solve #80

@sytone
Copy link
Owner

sytone commented Nov 18, 2023

Looks like a good solution, but what happens if an existing containers upgraded can the new containers to access the stuff under root from the non root account ?

@gmag11
Copy link
Contributor Author

gmag11 commented Nov 24, 2023

Yes, if you reassign owner of files to whatever PUID and GUID values you have set with chown -R...
If obsidian runs as root, all files created with be owned by root. With proposed changes files would be owned by PUID:GUID.

Test it in your system before merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants